Thread (2 messages) 2 messages, 2 authors, 2013-03-18

[PATCH] Input: tc3589x-keypad - fix row shift

flat view
STALE4955d

From: Rabin Vincent <hidden>
Date: 2013-03-11 15:54:27
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Dmitry Torokhov, Linus Torvalds

Since 1932811f426fee ("Input: matrix-keymap - uninline and prepare for
device tree support"), the row_shift used by the driver does not match
the one used by matrix_keypad_build_keymap(), leading to misdetection of
keys.  Fix it.

Cc: <redacted> # 3.8
Signed-off-by: Rabin Vincent <redacted>
---
 drivers/input/keyboard/tc3589x-keypad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tc3589x-keypad.c b/drivers/input/keyboard/tc3589x-keypad.c
index 208de7c..4ce924d 100644
--- a/drivers/input/keyboard/tc3589x-keypad.c
+++ b/drivers/input/keyboard/tc3589x-keypad.c
@@ -163,7 +163,7 @@ static int tc3589x_keypad_init_key_hardware(struct tc_keypad *keypad)
 #define TC35893_DATA_REGS		4
 #define TC35893_KEYCODE_FIFO_EMPTY	0x7f
 #define TC35893_KEYCODE_FIFO_CLEAR	0xff
-#define TC35893_KEYPAD_ROW_SHIFT	0x3
+#define TC35893_KEYPAD_ROW_SHIFT	0x4
 
 static irqreturn_t tc3589x_keypad_irq(int irq, void *dev)
 {
-- 
1.8.1.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help