Re: [patch] HID: hid-logitech-dj: add some range checks
From: Dan Carpenter <hidden>
Date: 2013-03-05 17:46:39
Also in:
kernel-janitors
From: Dan Carpenter <hidden>
Date: 2013-03-05 17:46:39
Also in:
kernel-janitors
On Tue, Mar 05, 2013 at 05:34:08PM +0100, Nestor Lopez Casado wrote:
quoted
If you want to add a check, it need to be in logi_dj_recv_forward_report(). The current access to djrcv_dev->paired_dj_devices[] in delayedwork_callback() has been removed in latest HID tree: https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/log/?h=for-3.10/logitechThe test could be added there. It would be quite defensive though, as we should always get the right device indexes.
Ah... I appologize for the noise. I misunderstood how hid_input_report() works. I thought it could be called with user supplied parameters. Never mind. regards, dan carpenter