Thread (39 messages) 39 messages, 8 authors, 2013-04-09

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

From: Fabio Porcedda <hidden>
Date: 2013-03-19 08:55:41
Also in: linux-arm-kernel, linux-fbdev, linux-ide, linux-media, lkml

On Mon, Mar 18, 2013 at 12:28 PM, Arnd Bergmann [off-list ref] wrote:
On Monday 18 March 2013, Fabio Porcedda wrote:
quoted
On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann [off-list ref] wrote:
quoted
On Monday 18 March 2013, Fabio Porcedda wrote:
quoted
Since by using platform_driver_probe() the  function
ep93xx_pwm_probe() is freed after initialization,
is better to use module_platform_drive_probe().
IMHO i don't see any good reason to use module_platform_driver() for
this driver.
As I commented earlier, the platform_driver_probe() and
module_platform_drive_probe() interfaces are rather dangerous in combination
with deferred probing, I would much prefer Harley's patch.
Since those drivers don't use -EPROBE_DEFER i was thinking that they don't use
deferred probing.
I'm missing something?
clk_get() may return -EPROBE_DEFER after ep93xx is converted to use the
common clk API. We currently return the value of clk_get from the probe()
function, which will automatically do the right thing as long as the probe
function remains reachable.
Thanks for the explanation.

Regards
Fabio Porcedda
        Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help