Re: [PATCH] input: st1232: Add IRQF_NO_SUSPEND flag
From: Magnus Damm <magnus.damm@gmail.com>
Date: 2013-02-15 01:46:09
Also in:
linux-sh
Hi Bastian, On Fri, Feb 15, 2013 at 2:32 AM, Bastian Hecht [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When registering the interrupt handler we add the IRQF_NO_SUSPEND flag to save the IRQ line from being disabled during suspension. This way we keep the ability to use the device as a wakeup source. Signed-off-by: Bastian Hecht <redacted> --- drivers/input/touchscreen/st1232.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c index d9d05e2..4f37199 100644 --- a/drivers/input/touchscreen/st1232.c +++ b/drivers/input/touchscreen/st1232.c@@ -180,7 +180,7 @@ static int st1232_ts_probe(struct i2c_client *client, input_set_abs_params(input_dev, ABS_MT_POSITION_Y, MIN_Y, MAX_Y, 0, 0); error = request_threaded_irq(client->irq, NULL, st1232_ts_irq_handler, - IRQF_ONESHOT, client->name, ts); + IRQF_ONESHOT | IRQF_NO_SUSPEND, client->name, ts);
Are you sure this is the correct way to handle this? Which platform have you tested this on? How about other boards? Usually wake up handling is dealt with separately from interrupts. Looks like something is missing in your interrupt controller code. Thanks, / magnus