Thread (16 messages) 16 messages, 4 authors, 2013-02-20

Re: [PATCH 2/7] input: atmel_mxt_ts: allow to read/display MXT_GEN_MESSAGE_T5 object

From: Daniel Kurtz <hidden>
Date: 2013-02-08 23:45:57

On Thu, Feb 7, 2013 at 6:17 AM, Peter Meerwald [off-list ref] wrote:
From: Peter Meerwald <redacted>
Hi Peter,

Hmm.  Why do you want to read T5?

We specifically removed T5 from the readble list in this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=55d6867fe659f4783e57db7b2ae0bb04e4ac816e

T5 is the message processor object.  Reading it will only have two
outcomes, neither of which is particularly useful:
1) the message count decrements, and a valid message will be lost
2) an invalid message will be read (reportid == 0xff)

Thanks!
-Daniel
quoted hunk ↗ jump to hunk
Signed-off-by: Peter Meerwald <redacted>
---
 drivers/input/touchscreen/atmel_mxt_ts.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen/atmel_mxt_ts.c
index fc52dc5..63a82bb 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -251,6 +251,7 @@ struct mxt_data {
 static bool mxt_object_readable(unsigned int type)
 {
        switch (type) {
+       case MXT_GEN_MESSAGE_T5:
        case MXT_GEN_COMMAND_T6:
        case MXT_GEN_POWER_T7:
        case MXT_GEN_ACQUIRE_T8:
--
1.7.9.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help