Re: [PATCH 6/7] HID: multitouch: remove usbhid dependency

Hi Henrik,

On Wed, Feb 20, 2013 at 9:25 PM, Henrik Rydberg [off-list ref] wrote:

Hi Benjamin,

quoted

Signed-off-by: Benjamin Tissoires <redacted>
---
 drivers/hid/hid-multitouch.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Since removing the transport layer dependency has a rationale, it
might be good to mention that here.

Ok, will do.

Also, what about the explicit usb dependency, was that going to be
moved to a usbhid quirk?

Currently, the USB dependency is protected by a check on the BUS.
The problem is that the BUS can be faked (by uhid). So yes, I'll add a
quirk under usbhid for those devices.

Cheers,
Benjamin

quoted

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 32258ba..184ac0a 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c

@@ -32,7 +32,6 @@
 #include <linux/slab.h>
 #include <linux/usb.h>
 #include <linux/input/mt.h>
-#include "usbhid/usbhid.h"


 MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");

@@ -907,7 +906,7 @@ static int mt_resume(struct hid_device *hdev)

      intf = to_usb_interface(hdev->dev.parent);
      interface = intf->cur_altsetting;
-     dev = hid_to_usb_dev(hdev);
+     dev = interface_to_usbdev(intf);

      /* Some Elan legacy devices require SET_IDLE to be set on resume.
       * It should be safe to send it to other devices too.
--

1.8.1

Thanks,
Henrik