Re: [PATCH v2 0/9] Support of Nexio 42" and new default class for hid-multitouch
From: Benjamin Tissoires <hidden>
Date: 2013-02-06 11:04:40
Also in:
lkml
On Tue, Feb 5, 2013 at 12:13 PM, Jiri Kosina [off-list ref] wrote:
On Mon, 4 Feb 2013, Henrik Rydberg wrote:quoted
quoted
Thanks for the review. However, before sending a new patch series, I'd like to have your answers to my comments as I mostly disagree on everything :)With good reason, apparently. :-) I see no major problem with your patches, although the discussed details show that there is room for some refactoring.Thanks to both of you. As I don't object to the HID core change, I have now applied the patchset, so please send any further additions on top of for-3.9/multitouch branch of my tree.
Ok. Thanks Jiri. I will send the patch in a minute.
Also, Benjamin, perhaps it'd make sense to put a link somewhere into in-tree documentation, with pointer to your testing suite?
Good idea. However, I prefer removing the dependencies between hid drivers and usbhid before including such reference to avoid testers getting kernel oops while trying to access the usb layer from the uhid device... So, yesterday and this morning, I rebased/updated Henrik's patches on this topic. They should be ready soon. Do you mind if I send the usbhid dependency and the pen+multitouch series this week, or we are too close to the 3.9 opening window? Cheers, Benjamin