Thread (3 messages) 3 messages, 2 authors, 2013-01-31

Re: [PATCH] HID: i2c-hid: fix i2c_hid_output_raw_report

From: Benjamin Tissoires <hidden>
Date: 2013-01-31 17:16:41
Also in: lkml

On Thu, Jan 31, 2013 at 5:58 PM, Jiri Kosina [off-list ref] wrote:
On Thu, 31 Jan 2013, Benjamin Tissoires wrote:
quoted
i2c_hid_output_raw_report is used by hidraw to forward set_report requests.
The current implementation of i2c_hid_set_report needs to take the
report_id as an argument. The report_id is stored in the first byte
of the buffer in argument of i2c_hid_output_raw_report.

Not removing the report_id from the given buffer adds this byte 2 times
in the command, leading to a non working command.

Reported-by: Andrew Duggan <redacted>
Signed-off-by: Benjamin Tissoires <redacted>
Applied, will push it for 3.8 still. Thanks,
Thanks Jiri!

Cheers,
Benjamin
--
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help