Thread (37 messages) 37 messages, 3 authors, 2013-01-28

Re: [PATCH 02/25] HID: multitouch: add support for Nexio 42" panel

From: Stéphane Chatty <hidden>
Date: 2013-01-28 17:03:46
Also in: lkml

Le 28 janv. 2013 à 16:01, Henrik Rydberg a écrit :
Hi Benjamin,
quoted
This device is the worst device I saw. It keeps TipSwitch and InRange
at 1 for fingers that are not touching the panel.
The solution is to rely on the field ContactCount, which is accurate
as the correct information are packed at the begining of the frame.

Unfortunately, CountactCount is most of the time at the end of the report.
The solution is to pick it when we have the whole report in raw_event.

Signed-off-by: Benjamin Tissoires <redacted>
---
drivers/hid/hid-ids.h        |  3 ++
drivers/hid/hid-multitouch.c | 91 ++++++++++++++++++++++++++++++++++++--------
2 files changed, 78 insertions(+), 16 deletions(-)
I think it would make more sense to introduce a method where the
driver sees all report values at once. We have had reasonable cause to
add it in the past, but never did.

I dreamed of this more than once in the early days of hid-multitouch, yes. But then it requires quite a few changes in hid-core.c, doesn't it?

Cheers,

St.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help