Re: [PATCH v2] HID: add ThingM blink(1) USB RGB LED support
From: Vivien Didelot <hidden>
Date: 2013-01-22 14:15:33
Also in:
lkml
From: Vivien Didelot <hidden>
Date: 2013-01-22 14:15:33
Also in:
lkml
quoted
The vendor's name is "ThingM" and the product's name is "blink(1)", not "blink". Given that, would you prefer to keep "blink(1)::1234", or would it rather be "thingm-blink1::1234" (avoiding parenthesis)? I ask the same question for the driver name, which is actually "blink(1)".Actually, for HID bus drivers, we are mostly following the convention of having just the vendor name in the driver, see hid-microsoft, hid-logitech, etc. So it'd make most sense to me to name the driver hid-thingm, and in case it is driving blink(1) device (no other devices will be driven by it currently), let it create /sys/class/leds/blink1...
Ok, makes sense to me! Thanks, Vivien