Re: [PATCH] drivers/input/keyboard/lm8323.c: fix incorrect left shift
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-01-05 23:01:33
Also in:
lkml
On Sat, Jan 05, 2013 at 02:09:05PM -0500, Nickolai Zeldovich wrote:
In drivers/input/keyboard/lm8323.c, INT_PWM1 is already a bitmask, not the bit number, so shifting by INT_PWM1 is incorrect. Signed-off-by: Nickolai Zeldovich <redacted>
Applied, thank you Nickolai.
quoted hunk
--- drivers/input/keyboard/lm8323.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c index 93c8126..0de23f4 100644 --- a/drivers/input/keyboard/lm8323.c +++ b/drivers/input/keyboard/lm8323.c@@ -398,7 +398,7 @@ static irqreturn_t lm8323_irq(int irq, void *_lm) lm8323_configure(lm); } for (i = 0; i < LM8323_NUM_PWMS; i++) { - if (ints & (1 << (INT_PWM1 + i))) { + if (ints & (INT_PWM1 << i)) { dev_vdbg(&lm->client->dev, "pwm%d engine completed\n", i); pwm_done(&lm->pwm[i]);-- 1.7.10.4
-- Dmitry