Re: [PATCH 1/1] Input: samsung-keypad: Add support for pinctrl

Hi Dmitry,

On 7 December 2012 00:59, Linus Walleij [off-list ref] wrote:

On Thu, Dec 6, 2012 at 11:18 AM, Sachin Kamat [off-list ref] wrote:

quoted

Added support for pin configuration using pinctrl subsystem
to the Samsung keypad driver.

Signed-off-by: Sachin Kamat <redacted>

So we've tried to add some pinctrl default fetchers into the input drivers
and Dmitry don't like sprinking calls like that all over the drivers so
we're trying to come up with some other scheme.

I sent one patch that tried to pick the pinctrl handles by using
notifiers but it doesn't work basically due to probe deferral.

So next approach will be to try and modify the device core to
fetch default pinctrl states.

You might try to lobby Dmitry to accepting this in the meantime,
as a stepping stone. (I'm OK with it, Acked-by).

What is your opinion about this patch? Can you please accept this
until we have some common scheme to handle this.

Yours,
Linus Walleij

-- 
With warm regards,
Sachin