[PATCH] HID: add quirk for Freescale i.MX23 ROM recovery

The USB recovery mode present in i.MX23 ROM emulates USB HID.
It needs this quirk to behave properly.

Even if the official branding of the chip is Freescale i.MX23,
I named it Sigmatel STMP3780 since that's what the chip really
is and it even reports itself as STMP3780.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Chen Peter <redacted>
Cc: Greg KH <redacted>
Cc: Jiri Kosina <redacted>
---
 drivers/hid/hid-ids.h           |    3 +++
 drivers/hid/usbhid/hid-quirks.c |    1 +
 2 files changed, 4 insertions(+)

NOTE: it'd be nice to include this in -stable eventually.

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 9d7a428..1ef9a9e 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h

@@ -696,6 +696,9 @@
 #define USB_VENDOR_ID_SIGMA_MICRO	0x1c4f
 #define USB_DEVICE_ID_SIGMA_MICRO_KEYBOARD	0x0002
 
+#define USB_VENDOR_ID_SIGMATEL		0x066F
+#define USB_DEVICE_ID_SIGMATEL_STMP3780	0x3780
+
 #define USB_VENDOR_ID_SKYCABLE			0x1223
 #define	USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER	0x3F07
 

diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 11c7932..0a1429f 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c

@@ -79,6 +79,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3001, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3008, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SENNHEISER, USB_DEVICE_ID_SENNHEISER_BTD500USB, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_SIGMATEL, USB_DEVICE_ID_SIGMATEL_STMP3780, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_1, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_2, HID_QUIRK_NOGET },

-- 
1.7.10.4

On Sat, 24 Nov 2012, Marek Vasut wrote:

The USB recovery mode present in i.MX23 ROM emulates USB HID.
It needs this quirk to behave properly.

Even if the official branding of the chip is Freescale i.MX23,
I named it Sigmatel STMP3780 since that's what the chip really
is and it even reports itself as STMP3780.

Applied, thanks Marek.

-- 
Jiri Kosina
SUSE Labs

Dear Jiri Kosina,

On Sat, 24 Nov 2012, Marek Vasut wrote:

quoted

The USB recovery mode present in i.MX23 ROM emulates USB HID.
It needs this quirk to behave properly.

Even if the official branding of the chip is Freescale i.MX23,
I named it Sigmatel STMP3780 since that's what the chip really
is and it even reports itself as STMP3780.

Applied, thanks Marek.

Thank you. It'd be nice to queue this for -stable too.

Best regards,
Marek Vasut

Hi Jirka,

On Sat, 24 Nov 2012, Marek Vasut wrote:

quoted

The USB recovery mode present in i.MX23 ROM emulates USB HID.
It needs this quirk to behave properly.

Even if the official branding of the chip is Freescale i.MX23,
I named it Sigmatel STMP3780 since that's what the chip really
is and it even reports itself as STMP3780.

Applied, thanks Marek.

Can we possibly push this into -stable please?

Best regards,
Marek Vasut

On Sat, Jan 12, 2013 at 09:22:48PM +0100, Marek Vasut wrote:

Hi Jirka,

quoted

On Sat, 24 Nov 2012, Marek Vasut wrote:

quoted

The USB recovery mode present in i.MX23 ROM emulates USB HID.
It needs this quirk to behave properly.

Even if the official branding of the chip is Freescale i.MX23,
I named it Sigmatel STMP3780 since that's what the chip really
is and it even reports itself as STMP3780.

Applied, thanks Marek.

Can we possibly push this into -stable please?

What is the git commit id of it in Linus's tree?  I need that before it
can go into a stable release.

thanks,

greg k-h

Hi Greg,

On Sat, Jan 12, 2013 at 09:22:48PM +0100, Marek Vasut wrote:

quoted

Hi Jirka,

quoted

On Sat, 24 Nov 2012, Marek Vasut wrote:

quoted

The USB recovery mode present in i.MX23 ROM emulates USB HID.
It needs this quirk to behave properly.

Even if the official branding of the chip is Freescale i.MX23,
I named it Sigmatel STMP3780 since that's what the chip really
is and it even reports itself as STMP3780.

Applied, thanks Marek.

Can we possibly push this into -stable please?

What is the git commit id of it in Linus's tree?  I need that before it
can go into a stable release.

This 436136cec650d661eb662fcb508a99878606d050 should be it, right ?

Thank you! I'll remember to supply the ID next time I prod anyone about stable 
stuff.

Best regards,
Marek Vasut

On Mon, Jan 14, 2013 at 10:02:21PM +0100, Marek Vasut wrote:

Hi Greg,

quoted

On Sat, Jan 12, 2013 at 09:22:48PM +0100, Marek Vasut wrote:

quoted

Hi Jirka,

quoted

On Sat, 24 Nov 2012, Marek Vasut wrote:

quoted

The USB recovery mode present in i.MX23 ROM emulates USB HID.
It needs this quirk to behave properly.

Even if the official branding of the chip is Freescale i.MX23,
I named it Sigmatel STMP3780 since that's what the chip really
is and it even reports itself as STMP3780.

Applied, thanks Marek.

Can we possibly push this into -stable please?

What is the git commit id of it in Linus's tree?  I need that before it
can go into a stable release.

This 436136cec650d661eb662fcb508a99878606d050 should be it, right ?

Ah, yes, that looks correct.

Thank you! I'll remember to supply the ID next time I prod anyone about stable 
stuff.

That would be great, that's all I really need in order to be able to
apply a patch.

greg k-h