Thread (3 messages) 3 messages, 2 authors, 2012-11-15

RE: [PATCH v6] Input: matrix-keypad - Add device tree support

From: AnilKumar, Chimata <hidden>
Date: 2012-11-15 14:11:59
Also in: linux-devicetree

On Thu, Nov 15, 2012 at 19:26:24, Rob Herring wrote:
On 11/15/2012 04:42 AM, AnilKumar Ch wrote:
quoted
Add device tree support to matrix keypad driver and usage details
are added to device tree documentation. Also modified the driver
according to recent update of matrix_keypad_build_keymap(), which
automatically allocate memory for keymap.

Signed-off-by: AnilKumar Ch <redacted>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
This patch was tested on AM335x-EVM and based on linux-next, cleanly
applies on top of "input/next"

Changes from v5:
	- Updated based on Dmitry's patch.
	  * Modified the driver acc. to matrix_keypad_build_keymap()
	    recent update.
	  * Combined row_gpios & col_gpios devm_kzalloc's to single
	    devm_kzalloc.
	  * Added proper return values for different failures in
	    matrix_keypad_parse_dt().

Changes from v4:
	- Removed clustered-irq support through DT. This should be
	  added if any platform requires in the future.

Changes from v3:
	- Incorporated Stephen Warren's review comments on v3
	  * Added description to clustered-irq-flags binding

Changes from v2:
	- Incorporated Stephen Warren's review comments on v2
	  * Renamed the bindings file to gpio-matrix-keypad.txt
	  * Added description to clustered-irq binding

Changes from v1:
	- Incorporated Rob's review comments on v1
	  * Changed matix-keypad compatible to gpio-matrix-keypad
	  * Removed unnecessary props (num of gpios)
	  * Used of_match_ptr()
	- Removed first patch based on Dmitry's comments on v1

 drivers/input/keyboard/matrix_keypad.c |  119 ++++++++++++++++++++++++++------
What happened to the binding doc?
Rebase mistake, right away I am resending the patch.

Thanks
AnilKumar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help