Re: [PATCH v4] Input: matrix-keypad - Add device tree support
From: Stephen Warren <hidden>
Date: 2012-11-08 16:55:33
Also in:
linux-devicetree
On 11/07/2012 02:32 AM, AnilKumar Ch wrote:
Add device tree support to matrix keypad driver and usage details are added to device tree documentation. Driver was tested on AM335x EVM.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
+Optional Properties:
+- clustered-irq: have clustered irq number, that is needed if the irq + is a combined irq source for the whole matrix keypad. + This is useful if rows and columns of the keypad are + connected to a GPIO expander. +- clustered-irq-flags: clustered irq flags to specify the interrupt line + behaviour among IRQF_TRIGGER_*
I still don't understand why there's a need for a clustered-irq-flags property; if those flags are the flags for an interrupt, why aren't the flags part of the clustered-irq interrupt specifier, just like any other interrupt in DT?