Thread (28 messages) 28 messages, 3 authors, 2013-01-16

Re: [PATCH 02/11] HID: hid-input: simplify hid_input allocation and registration

From: Jiri Kosina <hidden>
Date: 2012-11-27 20:19:50
Also in: lkml

On Tue, 27 Nov 2012, Henrik Rydberg wrote:
quoted
In order to provide fine control for the creation of different
input devices in probe function of third party drivers, this patch
split the allocations, the registrations and the free of input
devices.

Signed-off-by: Benjamin Tissoires <redacted>
---
 drivers/hid/hid-input.c | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)
I don't like this patch, nor its purpose. Drivers should not depend on
the hid core working in a particular way internally, that spells
disaster. There must be some other way in which the same effect can be
achieved?
The changelog doesn't seem to be really verbose enough to me.

What exactly is the scenario you are looking at here, Benjamin, please? 

Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help