Re: [PATCH] input: stmpe-ts: Add DT support for stmpe touchscreen
From: Lee Jones <hidden>
Date: 2012-11-23 12:05:09
Also in:
linux-devicetree, lkml
quoted
quoted
+++ b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt@@ -0,0 +1,43 @@ +STMPE Touchscreen +---------------- + +Required properties: + - compatible: "st,stmpe-ts"You shouldn't be specifying a compatible string in the DT.quoted
+Example: + + stmpe_touchscreen { + compatible = "st,stmpe-ts";This needs to be removed.Copying my earlier reply from stmpe-gpio patch for others to know what i have to say on this :) I believe these are required by the code you wrote in mfd-core.c if (parent->of_node && cell->of_compatible) { for_each_child_of_node(parent->of_node, np) { if (of_device_is_compatible(np, cell->of_compatible)) { pdev->dev.of_node = np; break; } } } This matches compatible of child node with compatible of cell. And that's why you have added that in your keypad mappings as well.
Yes, you're right. Please ignore this comment. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html