Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

From
Jiri Slaby <hidden>
Date
2012-11-04 22:37:37
Also in
lkml
Reply to
Geert Uytterhoeven, 2012-11-04
On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote:
On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby [off-list ref] wrote:
quoted
+       if ((quirks & MS_RDESC_3K) && *rsize == 106 &&
+                       !memcmp((char []){ 0x19, 0x00, 0x29, 0xff },
+                               &rdesc[94], 4)) {
Which version of gcc are you using?
4.7.1. But that indeed fails too if memcmp is a macro. This is of course
not the case for x86, so that I didn't hit that. I will post a patch to
change this to standard array accesses. (This looked prettier though.)

@Greg: please drop that patch from the stable queues for now.

thanks,
-- 
js
suse labs
Thread (6 messages) 6 messages, 3 authors, last reply 2012-11-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help