Re: [PATCH] sensor-hub: Remove pointless NULL check
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: 2012-10-18 18:57:35
Agreed. It was a mistake. Thanks, Srinivas On 10/09/2012 07:20 AM, Alan Cox wrote:
quoted hunk ↗ jump to hunk
From: Alan Cox <redacted> report cannot be NULL, fortunately as we use it before we check ! Signed-off-by: Alan Cox <redacted> --- drivers/hid/hid-sensor-hub.c | 4 ---- 1 file changed, 4 deletions(-)diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index d9d73e9..4ff2497 100644 --- a/drivers/hid/hid-sensor-hub.c +++ b/drivers/hid/hid-sensor-hub.c@@ -437,9 +437,6 @@ static int sensor_hub_raw_event(struct hid_device *hdev, ptr = raw_data; ptr++; /*Skip report id*/ - if (!report) - goto err_report; - spin_lock_irqsave(&pdata->lock, flags); for (i = 0; i < report->maxfield; ++i) {@@ -485,7 +482,6 @@ static int sensor_hub_raw_event(struct hid_device *hdev, callback->pdev); spin_unlock_irqrestore(&pdata->lock, flags); -err_report: return 1; }