Re: [PATCH 2/4] input: Convert struct i2c_msg initialization to C99 format
From: Dmitry Torokhov <hidden>
Date: 2012-10-13 06:19:22
Also in:
linux-i2c
Possibly related (same subject, not in this thread)
- 2012-10-10 · Re: [PATCH 2/4] input: Convert struct i2c_msg initialization to C99 format · Shubhrajyoti Datta <hidden>
- 2012-10-10 · Re: [PATCH 2/4] input: Convert struct i2c_msg initialization to C99 format · Jean Delvare <hidden>
- 2012-10-09 · [PATCH 2/4] input: Convert struct i2c_msg initialization to C99 format · Shubhrajyoti D <hidden>
On Wed, Oct 10, 2012 at 05:05:39PM +0530, Shubhrajyoti Datta wrote:
On Wed, Oct 10, 2012 at 2:32 PM, Jean Delvare [off-list ref] wrote:quoted
On Tue, 9 Oct 2012 17:01:18 +0530, Shubhrajyoti D wrote:[...]quoted
Acked-by: Jean Delvare <redacted>thanks updated patch below From 6638ecfa7982f95815382922c50573712c9626d7 Mon Sep 17 00:00:00 2001 From: Shubhrajyoti D <redacted> Date: Mon, 17 Sep 2012 19:37:17 +0530 Subject: [PATCHv2 1/2] input: Convert struct i2c_msg initialization to C99 format Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Thanks to Julia Lawall [off-list ref] for automating the conversion Acked-by: Jean Delvare <redacted> Signed-off-by: Shubhrajyoti D <redacted>
Applied both, thanks Shubhrajyoti.
quoted hunk
--- drivers/input/touchscreen/cy8ctmg110_ts.c | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-)diff --git a/drivers/input/touchscreen/cy8ctmg110_ts.cb/drivers/input/touchscreen/cy8ctmg110_ts.c index 464f1bf..ad6a664 100644--- a/drivers/input/touchscreen/cy8ctmg110_ts.c +++ b/drivers/input/touchscreen/cy8ctmg110_ts.c@@ -99,9 +99,18 @@ static int cy8ctmg110_read_regs(struct cy8ctmg110 *tsc, int ret; struct i2c_msg msg[2] = { /* first write slave position to i2c devices */ - { client->addr, 0, 1, &cmd }, + { + .addr = client->addr, + .len = 1, + .buf = &cmd + }, /* Second read data from position */ - { client->addr, I2C_M_RD, len, data } + { + .addr = client->addr, + .flags = I2C_M_RD, + .len = len, + .buf = data + } }; ret = i2c_transfer(client->adapter, msg, 2);-- 1.7.5.4
-- Dmitry