Re: [PATCH V3 1/4] Input: pxa27x_keypad keep clock on as wakeup source

On Fri, Apr 27, 2012 at 12:04 PM, Haojian Zhuang
[off-list ref] wrote:

On Mon, Apr 2, 2012 at 5:37 PM, Haojian Zhuang [off-list ref] wrote:

quoted

On Sun, Apr 1, 2012 at 10:08 AM, Chao Xie [off-list ref] wrote:

quoted

When the keypad is used as wake up source, the clock can not
be disabled. Or it can not detect key pressing.
If the keypad is used as wake up source, when resume back,
do not enable the clock and configure it again because the
register content is retained.

Signed-off-by: Chao Xie <redacted>
---

Hi Dmitry,

I just found that you're not looped in this mail thread. Could I merge
them into arch-pxa tree?

Best Regards
Haojian

Applied

Regards
Haojian

Hi,

This patch breaks pxa27x_keypad on pxa270-based Zipit Z2 device. After
resume keypad is not working anymore.
Reverting this patch fixes issue. Looks like it's necessary to call
pxa27x_keypad_config() on resume (at least on pxa27x?)

Regards
Vasily