Re: [PATCH v2 06/11] HID: hid-multitouch: support T and C for win8 devices
From: Henrik Rydberg <hidden>
Date: 2012-10-31 18:43:09
Also in:
lkml
quoted
quoted
+ usage_index) { + hid_map_usage(hi, usage, bit, max, + EV_ABS, ABS_MT_TOOL_X); + set_abs(hi->input, ABS_MT_TOOL_X, field, + cls->sn_move); + } else { + hid_map_usage(hi, usage, bit, max, EV_ABS, ABS_MT_POSITION_X); - set_abs(hi->input, ABS_MT_POSITION_X, field, - cls->sn_move); + set_abs(hi->input, ABS_MT_POSITION_X, field, + cls->sn_move); + } +Do we really want to do the latter several times, even if the device is not a win8 one?I don't get your point here. The only difference with the previous release is that it will treat differently the first in the array than the others. For non win8 devices, there is no changes in the behavior. Could you elaborate a little bit more, please?
I was wondering what we want to do about multiple reports in the general casel. Not that important though, the patch will probably look fine in your next version. Thanks, Henrik