Re: [PATCH] ti_tscadc: Match mfd sub devices to regmap interface
From: Lars-Peter Clausen <hidden>
Date: 2012-10-30 18:21:39
Also in:
linux-iio, linux-omap, lkml
On 10/31/2012 04:55 PM, Pantelis Antoniou wrote:
The MFD parent device now uses a regmap, instead of direct memory access. Use the same method in the sub devices to avoid nasty surprises. Also rework the channel initialization of tiadc a bit.
Those two bits are not even closely related, they should really go into separate patches.
Signed-off-by: Pantelis Antoniou <panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org> --- drivers/iio/adc/ti_am335x_adc.c | 27 +++++++++++++++++++-------- drivers/input/touchscreen/ti_am335x_tsc.c | 16 +++++++++++++--- drivers/mfd/ti_am335x_tscadc.c | 7 +++++-- 3 files changed, 37 insertions(+), 13 deletions(-)
[...]
quoted hunk ↗ jump to hunk
@@ -213,6 +222,8 @@ static int __devinit tiadc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, indio_dev); + dev_info(&pdev->dev, "Initialized\n");
That's just noise, please don't add it. Imagine every driver did this you'd end up with a lot of noise your debug log.
quoted hunk ↗ jump to hunk
+ return 0; err_free_channels:diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index 7a26810..d09e1a7 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c@@ -26,6 +26,7 @@
[...]
quoted hunk ↗ jump to hunk
/*@@ -455,10 +460,15 @@ static int __devinit titsc_probe(struct platform_device *pdev) /* register to the input system */ err = input_register_device(input_dev); - if (err) + if (err) { + dev_err(&pdev->dev, "Failed to register input device\n"); goto err_free_irq; + } platform_set_drvdata(pdev, ts_dev); + + dev_info(&pdev->dev, "Initialized OK\n");
Same here