Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices

Hi Alexandra,

On Thu, Oct 04, 2012 at 05:52:45AM +0000, Alexandra Chin wrote:

From: Henrik Rydberg
Sent: Thursday, October 04, 2012 2:01 AM

quoted

It seems this driver is already present in staging. Comments and
formatting have been improved in the staging version, but that aside,
the two versions look very similar.  Why don't you submit fixes to
that driver instead?

quoted

On a general note, both versions of the driver use MT-A. Please
convert to MT-B, using the in-kernel tracking if necessary.

Hi Henrik,

Appreciate your suggestion!
We are going to update a patch of using MT-B, because Synaptics devices are 
capable of tracking identifiable contacts (type B).
Thanks for pointing out this.

You are right, there is already a synaptics_i2c_rmi4 driver in staging 
state (drivers/staging/ste_rmi4). 
Actually synaptics_ds4_i2c driver is developed based on synaptics_i2c_rmi4 
driver. The point is that we would want to make a clear definition that 
synaptics_ds4_i2c only targets to DS4 family, so that we can keep maintaining 
driver focusing on DS4 product line (not all Synaptics touchscreen devices are 
DS4 compatible).

Given that the other group at Synaptics works on general version of RMI4
driver what is the benefit of having separate driver for DS4 line? I can
understand keeping one copy of older driver in staging so that some
customers coudl still use hardware while universal implementation is
being developed, but I do not see why we would want to have 3 separate
drivers.

Thanks.

-- 
Dmitry