Thread (2 messages) 2 messages, 2 authors, 2012-09-26

Re: [PATCH] atmel_mxt: simplify mxt_dump_message

flat view

From: Daniel Kurtz <hidden>
Date: 2012-09-26 14:18:41

On Wed, Sep 26, 2012 at 7:05 PM, Andy Shevchenko
[off-list ref] wrote:
This patch applies %*ph to print small buffer and marks function as inline.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Daniel Kurtz <redacted>
quoted hunk ↗ jump to hunk

---
 drivers/input/touchscreen/atmel_mxt_ts.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index e92615d..211bfb4 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -317,13 +317,11 @@ static bool mxt_object_writable(unsigned int type)
        }
 }

-static void mxt_dump_message(struct device *dev,
-                            struct mxt_message *message)
+static inline void mxt_dump_message(struct device *dev,
+                                   struct mxt_message *message)
 {
-       dev_dbg(dev, "reportid: %u\tmessage: %02x %02x %02x %02x %02x %02x %02x\n",
-               message->reportid, message->message[0], message->message[1],
-               message->message[2], message->message[3], message->message[4],
-               message->message[5], message->message[6]);
+       dev_dbg(dev, "reportid: %u\tmessage: %*ph\n",
+               message->reportid, 7, message->message);
 }

 static int mxt_check_bootloader(struct i2c_client *client,
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help