Thread (4 messages) flat view 4 messages, 3 authors, 2012-09-18

Re: [PATCH] HID: wiimote: fix weight conversion error for values > 17kg

From: David Herrmann <hidden>
Date: 2012-09-17 21:08:27

On Mon, Sep 17, 2012 at 9:15 PM, Florian Echtler [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-Off-By: Florian Echtler <redacted>
---
 drivers/hid/hid-wiimote-ext.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-wiimote-ext.c b/drivers/hid/hid-wiimote-ext.c
index fc98cc9..bc85bf2 100644
--- a/drivers/hid/hid-wiimote-ext.c
+++ b/drivers/hid/hid-wiimote-ext.c
@@ -585,7 +585,8 @@ static void handler_balance_board(struct wiimote_ext
*ext, const __u8 *payload)
                } else {
                        tmp = val[i] - ext->calib[i][1];
                        tmp *= 1700;
-                       tmp /= ext->calib[i][2] - ext->calib[i][1] + 1700;
+                       tmp /= ext->calib[i][2] - ext->calib[i][1];
+                       tmp += 1700;
That's the reason why I split up your extra long line from the
original :P I should have checked it again. Thanks for the fix. I've
compared it with the original and I messed it up during conversion.
Sorry.

Signed-off-by: David Herrmann <redacted>

Thanks Jiri for applying them.
David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help