Re: [Patch v1 7/7] DA9055 Onkey driver

On Mon, 2012-09-17 at 16:28 +0530, Ashish Jangam wrote:

-----Original Message-----
From: Laxman Dewangan [mailto:ldewangan@nvidia.com] 
Sent: Friday, September 14, 2012 6:48 PM
To: Ashish Jangam
Cc: Liam Girdwood; Samuel Ortiz; linux-input@vger.kernel.org; David Dajun Chen
Subject: Re: [Patch v1 7/7] DA9055 Onkey driver

On Friday 14 September 2012 07:04 PM, Ashish Jangam wrote:

quoted

+static irqreturn_t da9055_onkey_irq(int irq, void *data)
+{
+	struct input_dev *input_dev = data;
+
+	input_report_key(input_dev, KEY_POWER, 1);

When do you send the release key event?

Well DA9055 does not have any irq/register that provides onkey button
current state and cannot depend on event register since it gets cleared
by regmap. It seems I should use status register to send release key
event. I will implement this and re-submit the patch.

Overall driver looks like you can use the gpio-key driver with passing 
irq number, without passing gpio.

Yes, logic can be referred.

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------