Re: [PATCH] HID: Fix return value in hid-core.c
From: Jiri Kosina <hidden>
Date: 2012-09-17 11:02:35
On Fri, 14 Sep 2012, Sachin Kamat wrote:
quoted hunk ↗ jump to hunk
Return -ENOMEM instead of -1 if memory allocation fails. Signed-off-by: Sachin Kamat <redacted> --- drivers/hid/hid-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 16d6454..1011a22 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c@@ -134,7 +134,7 @@ static int open_collection(struct hid_parser *parser, unsigned type) parser->device->collection_size * 2, GFP_KERNEL); if (collection == NULL) { hid_err(parser->device, "failed to reallocate collection array\n"); - return -1; + return -ENOMEM;
While you are at it, could you please update the return value in case the collection stack overflows? I'd go with EINVAL. Thanks.
} memcpy(collection, parser->device->collection, sizeof(struct hid_collection) * -- 1.7.4.1
-- Jiri Kosina SUSE Labs