Thread (3 messages) 3 messages, 3 authors, 2012-09-17

Re: [PATCH] HID: lenovo-tpkbd: Fix memory leak in tpkbd_remove_tp()

From: Jiri Kosina <hidden>
Date: 2012-09-17 10:56:46

On Fri, 14 Sep 2012, Bernhard Seibold wrote:
On Thu, 13 Sep 2012 13:25:12 +0800
Axel Lin [off-list ref] wrote:
quoted
We need to kfree names for led_mute and led_micmute in
tpkbd_remove_tp().

Signed-off-by: Axel Lin <redacted>
Acked-by: Bernhard Seibold <redacted>
Applied, thanks.
quoted
---
 drivers/hid/hid-lenovo-tpkbd.c |    2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-lenovo-tpkbd.c
b/drivers/hid/hid-lenovo-tpkbd.c index 77d2df0..60c4e1e 100644
--- a/drivers/hid/hid-lenovo-tpkbd.c
+++ b/drivers/hid/hid-lenovo-tpkbd.c
@@ -519,6 +519,8 @@ static void tpkbd_remove_tp(struct hid_device
*hdev) led_classdev_unregister(&data_pointer->led_mute);
 
 	hid_set_drvdata(hdev, NULL);
+	kfree(data_pointer->led_micmute.name);
+	kfree(data_pointer->led_mute.name);
 	kfree(data_pointer);
 }
 
-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help