[PATCH RFT] HID: sensor-hub: don't hold spin lock while calling kzalloc with GFP_KERNEL
STALE5130d
From: Axel Lin <hidden>
Date: 2012-09-16 02:58:33
Subsystem:
hid core layer, hid sensor hub drivers, the rest · Maintainers:
Jiri Kosina, Benjamin Tissoires, Jonathan Cameron, Srinivas Pandruvada, Linus Torvalds
kzalloc might cause sleep, so don't hold spin lock while calling kzalloc with GFP_KERNEL. Signed-off-by: Axel Lin <redacted> --- drivers/hid/hid-sensor-hub.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 4ac759c..162bf6a 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c@@ -173,14 +173,17 @@ int sensor_hub_register_callback(struct hid_sensor_hub_device *hsdev, spin_unlock(&pdata->dyn_callback_lock); return -EINVAL; } + spin_unlock(&pdata->dyn_callback_lock); + callback = kzalloc(sizeof(*callback), GFP_KERNEL); - if (!callback) { - spin_unlock(&pdata->dyn_callback_lock); + if (!callback) return -ENOMEM; - } + callback->usage_callback = usage_callback; callback->usage_id = usage_id; callback->priv = NULL; + + spin_lock(&pdata->dyn_callback_lock); list_add_tail(&callback->list, &pdata->dyn_callback_list); spin_unlock(&pdata->dyn_callback_lock);
--
1.7.9.5