Re: [PATCH] input: fix input_open_file() accessing out-of-bound buffers
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2012-09-13 16:57:23
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2012-09-13 16:57:23
Hi David, On Thu, Sep 13, 2012 at 06:18:17PM +0200, David Herrmann wrote:
Hi Dmitry On Thu, Sep 13, 2012 at 6:17 PM, David Herrmann [off-list ref] wrote:quoted
The "input_table" array is very small and we cannot be sure that the file the user opens has a minor-ID below 256 (8 << 5). Hence, simply check that the minor isn't out-of-bounds. If it is, return -ENODEV. Signed-off-by: David Herrmann <redacted> Cc: <stable@kernel.org>This should be "Cc: [off-list ref]". Sorry for the typo.
register_chrdev() reserves exactly 256 minors so it is not possible for input_open_file() to be called with minor that will get us out of bounds. Thanks. -- Dmitry