Re: [PATCHv2 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
From: Mark Brown <hidden>
Date: 2012-09-25 17:53:07
Also in:
linux-arm-kernel, linux-devicetree, linux-omap, lkml
On Wed, Sep 05, 2012 at 05:06:04PM +0530, Sourav Poddar wrote:
+static struct regmap_config smsc_regmap_config = {
+ .reg_bits = 8,
+ .val_bits = 8,
+ .max_register = SMSC_MAX_REGISTER - 1;
+ .cache_type = REGCACHE_COMPRESSED,
+};That definition of max_register looks wrong - why are we subtracting 1 from a macro called MAX_REGISTER to get it? Indentation here is a bit odd too.
+static int smsc_i2c_remove(struct i2c_client *i2c)
+{
+ return 0;
+}Remove empty functions.