Thread (10 messages) 10 messages, 2 authors, 2012-09-25

Re: [PATCH v2 0/3] input: Dynamic Minor Numbers

From: David Herrmann <hidden>
Date: 2012-09-21 19:18:06
Also in: lkml

Hi Dmitry

On Fri, Sep 21, 2012 at 11:22 AM, David Herrmann
[off-list ref] wrote:
Hi Dmitry

On Fri, Sep 21, 2012 at 10:07 AM, Dmitry Torokhov
[off-list ref] wrote:
quoted
Thank you very much for working on this, unfortunately your patch extends the
existing infrastructure handling of character devices in input core,
which is quite rigid and sub-optimal.

For a while now I wanted to stop input core from pre-creating character
devices and multiplexing file operations and instead push more chardev
handling tasks into individual input handlers and make they more
independent from input core. So while I won't be taking your patch as is
it was a great motivator to finally do something about current
limitation and I would appreciate if you could take a look at the patch
below and see if you have any issues with it.
I didn't know why we did that, anyway. But I tried to keep that logic,
even though it is really weird. So I am quite glad that you fixed it.
Sorry, compiling a kernel takes 44m here so I haven't had time earlier
this day. But I just recompiled with your patch and it works like a
charm. I have attached output of "ls -la /dev/input" with 900 uinput
devices. Performance does suck but that is definitely another issue.

So here's my:
Tested-by: David Herrmann <redacted>

I will review the rest tomorrow.
Cheers
David

Attachments

  • lx_output [application/octet-stream] 43732 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help