Re: [PATCH 2/5] MFD: ti_tscadc: Add support for TI's TSC/ADC MFDevice
From: Samuel Ortiz <hidden>
Date: 2012-09-19 15:31:28
Also in:
linux-iio, lkml
Hi Rachna A couple of comments: On Thu, Aug 23, 2012 at 04:19:57PM +0530, Patil, Rachna wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index d1facef..81eb815 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig@@ -94,6 +94,15 @@ config MFD_TI_SSP To compile this driver as a module, choose M here: the module will be called ti-ssp. +config MFD_TI_TSCADC + tristate "TI ADC / Touch Screen chip support" + depends on ARCH_OMAP2PLUS
What makes it OMAP2PLUS or even ARCH specific at all ?
+static unsigned int tscadc_readl(struct ti_tscadc_dev *tsadc, unsigned int reg)
+{
+ return readl(tsadc->tscadc_base + reg);
+}
+
+static void tscadc_writel(struct ti_tscadc_dev *tsadc, unsigned int reg,
+ unsigned int val)
+{
+ writel(val, tsadc->tscadc_base + reg);
+}Please use regmap MMIO for that stuff. It won't make the code shorter, but more robust. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/