RE: [PATCH v3 5/5] MFD: ti_tscadc: add suspend/resume functionality

From
Patil, Rachna <hidden>
Date
2012-09-14 04:59:46
Also in
linux-iio, lkml
Reply to
Lars-Peter Clausen, 2012-09-13
On Thu, Sep 13, 2012 at 18:31:35, Lars-Peter Clausen wrote:
On 09/13/2012 12:40 PM, Patil, Rachna wrote:
quoted
This patch adds support for suspend/resume of TSC/ADC MFDevice.

Signed-off-by: Patil, Rachna <redacted>
---
Changes in v2:
	Added this patch newly in this patch series.

Changes in v3:
	No changes.

 drivers/iio/adc/ti_adc.c           |   32 ++++++++++++++++++++++++++++++++
 drivers/input/touchscreen/ti_tsc.c |   33 +++++++++++++++++++++++++++++++++
 drivers/mfd/ti_tscadc.c            |   33 ++++++++++++++++++++++++++++++++-
 include/linux/mfd/ti_tscadc.h      |    3 +++
 4 files changed, 100 insertions(+), 1 deletions(-)
diff --git a/drivers/iio/adc/ti_adc.c b/drivers/iio/adc/ti_adc.c index 
56f8af2..69f19f0 100644
--- a/drivers/iio/adc/ti_adc.c
+++ b/drivers/iio/adc/ti_adc.c
@@ -207,6 +207,36 @@ static int __devexit tiadc_remove(struct platform_device *pdev)
 	return 0;
 }
 
[...]
quoted
 static struct platform_driver tiadc_driver = {
 	.driver = {
 		.name   = "tiadc",
@@ -214,6 +244,8 @@ static struct platform_driver tiadc_driver = {
 	},
 	.probe	= tiadc_probe,
 	.remove	= __devexit_p(tiadc_remove),
+	.suspend = adc_suspend,
+	.resume = adc_resume,
 };
 

Using the suspend/resume callbacks is deprecated, please use dev_pm_ops.
Same comment applies to the other two drivers.
Ok. I will make changes in all the 3 driver to use dev_pm_ops instead of suspend/resume callbacks.

Regards,
Rachna
Thread (17 messages) 17 messages, 5 authors, last reply 2012-09-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help