Thread (5 messages) flat view 5 messages, 2 authors, 2012-09-07
STALE5094d

[PATCH 1/2] HID: Allow more fields in the hid report

From: Henrik Rydberg <hidden>
Date: 2012-09-05 15:21:32
Also in: lkml
Subsystem: hid core layer, the rest · Maintainers: Jiri Kosina, Benjamin Tissoires, Linus Torvalds

Some recent hardware define more than 128 fields in the report
descriptor. Increase the limit to 256. This adds another kilobyte of
memory per report.

Signed-off-by: Henrik Rydberg <redacted>
---
Hi Jiri,

The Flatfrog panel (next patch) reports 188 fields, so 256 seems like
a fair number. I am not overly thrilled about this patch, but the
alternative looks like a major change. At least it will be easy to
backport. :-)

Thanks,
Henrik

 include/linux/hid.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index f37da28..7e1f37d 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -414,7 +414,7 @@ struct hid_field {
 	__u16 dpad;			/* dpad input code */
 };
 
-#define HID_MAX_FIELDS 128
+#define HID_MAX_FIELDS 256
 
 struct hid_report {
 	struct list_head list;
-- 
1.7.12
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help