Re: [RFC PATCH 5/17] input: rmidev character driver for RMI4 sensors

On Wed, Sep 5, 2012 at 2:26 AM, Christopher Heiny [off-list ref] wrote:

On 08/27/2012 11:49 AM, Linus Walleij wrote:

quoted

You need to patch your desired major number into
Documentation/devices.txt'

We were going by the recommendation in Linux Device Drivers (3rd edition) to
use dynamic major number allocation via alloc_chrdev_region.  In particular
in section 3.2.3 it says "new numbers are not being assigned".  I guess at
this point we need to know whether the info in LDD3 is authoritative or not.

You're right, go for dynamic numbers. I was plain wrong.

quoted

quoted

+static struct class *rmidev_device_class;

Last time discussed with Greg, class devices were deprecated,
and you should just use a bus instead. (But not sure.)

The references I found online weren't clear on this, so more investigation
is required.  We'll defer that till we find out if the regmap changes
eliminate the need for this.

Just push Greg to review next version and he'll tell you what to
do about this, no problem.

Yours,
Linus Walleij