[PATCH] Input: Fix edt-ft5x06 build error seen if CONFIG_DEBUG_FS is not defined

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE5120d

2 messages, 2 authors, 2012-08-07 · open the first message on its own page

[PATCH] Input: Fix edt-ft5x06 build error seen if CONFIG_DEBUG_FS is not defined

From: Guenter Roeck <linux@roeck-us.net>
Date: 2012-08-07 03:02:10

Fix:

edt-ft5x06.c: In function edt_ft5x06_ts_remove:
edt-ft5x06.c:846:14: error: struct edt_ft5x06_ts_data has no member named
raw_buffer

Cc: Simon Budig <redacted>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/input/touchscreen/edt-ft5x06.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 9afc777..b06a5e3 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -602,6 +602,7 @@ edt_ft5x06_ts_teardown_debugfs(struct edt_ft5x06_ts_data *tsdata)
 {
 	if (tsdata->debug_dir)
 		debugfs_remove_recursive(tsdata->debug_dir);
+	kfree(tsdata->raw_buffer);
 }
 
 #else
@@ -843,7 +844,6 @@ static int __devexit edt_ft5x06_ts_remove(struct i2c_client *client)
 	if (gpio_is_valid(pdata->reset_pin))
 		gpio_free(pdata->reset_pin);
 
-	kfree(tsdata->raw_buffer);
 	kfree(tsdata);
 
 	return 0;
-- 
1.7.9.7

Re: [PATCH] Input: Fix edt-ft5x06 build error seen if CONFIG_DEBUG_FS is not defined

From: Simon Budig <hidden>
Date: 2012-08-07 10:01:20

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/07/2012 05:02 AM, Guenter Roeck wrote:
Fix:

edt-ft5x06.c: In function edt_ft5x06_ts_remove: 
edt-ft5x06.c:846:14: error: struct edt_ft5x06_ts_data has no member
named raw_buffer
Oops sorry, forgot to test compiling the driver without DEBUGFS. The
change looks correct to me.

Bye,
        Simon
- -- 
       Simon Budig                        kernel concepts GmbH
       simon.budig@kernelconcepts.de      Sieghuetter Hauptweg 48
       +49-271-771091-17                  D-57072 Siegen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlAg52sACgkQO2O/RXesiHC79gCfUyq8IGeS2rau3myvrtU6Bo4O
hiIAniXUa0AIzWJSvJ0gsQMgNA+1hnwd
=JBXZ
-----END PGP SIGNATURE-----
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help