Thread (4 messages) flat view 4 messages, 3 authors, 2012-08-15

Re: [PATCH 1/2] HID: wacom: Use half of brightness for low state

From: Ping Cheng <hidden>
Date: 2012-08-03 17:42:42

On Tue, Jul 31, 2012 at 10:27 AM, Przemo Firszt [off-list ref] wrote:
Intuos4 WL leds have 2 states: high and low. With no activity tablet
uses low state; using pen triggers high state. Both can be set
independently, but it would require setting another led device to
control them separately. This patch uses the brightness set through leds
subsytem as high and half of that value as low.

Signed-off-by: Przemo Firszt <redacted>
Acked-by: Ping Cheng <redacted> for the whole set.

Thank you, Przemo, for your effort.

Ping
quoted hunk ↗ jump to hunk
---
 drivers/hid/hid-wacom.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index fe23a1e..848842e 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -91,7 +91,8 @@ static void wacom_leds_set_brightness(struct led_classdev *led_dev,
        if (buf) {
                buf[0] = WAC_CMD_LED_CONTROL;
                buf[1] = led;
-               buf[2] = value;
+               buf[2] = value >> 2;
+               buf[3] = value;
                hdev->hid_output_raw_report(hdev, buf, 9, HID_FEATURE_REPORT);
                kfree(buf);
        }
--
1.7.10.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help