Re: [PATCH 1/8] mfd: Add Dialog DA906x core driver.

On Fri, Aug 31, 2012 at 12:20:00PM +0100, Krystian Garbaciak wrote:

quoted

On Fri, Aug 24, 2012 at 02:50:00PM +0100, Krystian Garbaciak wrote:

quoted

Your selection of people to CC here appears both large and random...

I've added any maintainer for my modules from maintainer list.

You don't need to CC every single persojn on every single patch, and
quite a few of these people are clearly not active in development.

quoted

quoted

+inline unsigned int da906x_to_range_reg(u16 reg)
+{
+	return reg + DA906X_MAPPING_BASE;
+}

quoted

I've no real idea what this stuff is all about, it at least needs some
comments somewhere.  The fact that you're just adding a constant offset
to all registers is at best odd.

I will comment it precisely for next version:

This still makes very little sense - this function appears to be
accomplishing very little.  You're adding a constant offset to every
single register address that gets used.  Why are we doing this
dynamically at runtime?