Re: [PATCH] Input: Let the FT5x06 driver build without debugfs
5 messages,
4 authors,
2012-08-30 · open the first message on its own page
Simon Budig [off-list ref] writes:
On 08/17/2012 02:15 AM, Eric W. Biederman wrote: quoted When testing to make certain my user namespace code works in
various configurations I tripped over the tf5x06.c not building
with debugfs disabled.
Sorry for that.
There already is a patch for this issue which I slightly prefer. You
can find it in the mail from Guenther Roeck:
http://www.mail-archive.com/linux-input@vger.kernel.org/msg00646.html
If you guys could get that merged into 3.6 I would appreciate it.
Thanks,
Eric
On Fri, Aug 17, 2012 at 12:21:34PM -0700, Eric W. Biederman wrote: Simon Budig [off-list ref] writes:
quoted On 08/17/2012 02:15 AM, Eric W. Biederman wrote: quoted When testing to make certain my user namespace code works in
various configurations I tripped over the tf5x06.c not building
with debugfs disabled.
Sorry for that.
There already is a patch for this issue which I slightly prefer. You
can find it in the mail from Guenther Roeck:
http://www.mail-archive.com/linux-input@vger.kernel.org/msg00646.html
If you guys could get that merged into 3.6 I would appreciate it. Yes, that would be great. I don't recall seeing an e-mail from Dmitry accepting
it, though.
Guenter
On Mon, Aug 20, 2012 at 06:53:03AM -0700, Guenter Roeck wrote: On Fri, Aug 17, 2012 at 12:21:34PM -0700, Eric W. Biederman wrote: quoted Simon Budig [off-list ref] writes:
quoted On 08/17/2012 02:15 AM, Eric W. Biederman wrote: quoted When testing to make certain my user namespace code works in
various configurations I tripped over the tf5x06.c not building
with debugfs disabled.
Sorry for that.
There already is a patch for this issue which I slightly prefer. You
can find it in the mail from Guenther Roeck:
http://www.mail-archive.com/linux-input@vger.kernel.org/msg00646.html
If you guys could get that merged into 3.6 I would appreciate it. Yes, that would be great. I don't recall seeing an e-mail from Dmitry accepting
it, though.
Applied, sorry for the delay.
--
Dmitry
On Tue, 21 Aug 2012, Dmitry Torokhov wrote:
quoted quoted quoted On 08/17/2012 02:15 AM, Eric W. Biederman wrote: quoted When testing to make certain my user namespace code works in
various configurations I tripped over the tf5x06.c not building
with debugfs disabled.
Sorry for that.
There already is a patch for this issue which I slightly prefer. You
can find it in the mail from Guenther Roeck:
http://www.mail-archive.com/linux-input@vger.kernel.org/msg00646.html
If you guys could get that merged into 3.6 I would appreciate it. Yes, that would be great. I don't recall seeing an e-mail from Dmitry accepting
it, though.
Applied, sorry for the delay.
This still affects Linus' tree and causes a build breakage without debugfs
configured. Considering the driver went into 3.5-rc5, could you please
push this fix for 3.6 (and mark it for stable backport)?
On Thu, Aug 30, 2012 at 03:26:21PM -0700, David Rientjes wrote: On Tue, 21 Aug 2012, Dmitry Torokhov wrote:
quoted quoted quoted quoted On 08/17/2012 02:15 AM, Eric W. Biederman wrote: quoted When testing to make certain my user namespace code works in
various configurations I tripped over the tf5x06.c not building
with debugfs disabled.
Sorry for that.
There already is a patch for this issue which I slightly prefer. You
can find it in the mail from Guenther Roeck:
http://www.mail-archive.com/linux-input@vger.kernel.org/msg00646.html
If you guys could get that merged into 3.6 I would appreciate it. Yes, that would be great. I don't recall seeing an e-mail from Dmitry accepting
it, though.
Applied, sorry for the delay.
This still affects Linus' tree and causes a build breakage without debugfs
configured. Considering the driver went into 3.5-rc5, could you please
push this fix for 3.6
I Just sent a pull request to Linus.
(and mark it for stable backport)?
I am pretty sure it was merged in 3.6 merge window, not 3.5, so no need
to mark for stable.
Thanks.
--
Dmitry