Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device
From: Yann Cantin <hidden>
Date: 2012-08-07 01:21:09
Also in:
lkml
Le 07/08/2012 00:07, Dmitry Torokhov a écrit :
On Monday, August 06, 2012 02:43:40 PM Greg KH wrote:quoted
On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote:quoted
Signed-off-by: Yann Cantin <redacted> --- drivers/hid/hid-core.c | 3 +++ drivers/hid/hid-ids.h | 3 +++ 2 files changed, 6 insertions(+)diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 60ea284..b1ed8ee 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c@@ -1908,6 +1908,9 @@ static const struct hid_device_id hid_ignore_list[]= {> { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) }, { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x0004) }, { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x000a) }, +#if defined(CONFIG_INPUT_EBEAM_USB) + { HID_USB_DEVICE(USB_VENDOR_ID_EFI, USB_DEVICE_ID_EFI_CLASSIC) }, +#endifWhy is this #if in here? Just always do it, how could it not be defined?User might disable the driver and CONFIG_INPUT_EBEAM_USB will not be set. But I agree, since the device is unusable with generic HID driver there is no point in doing this conditionally.
There's a closed-source user-space stack (libusb based daemon + xorg driver + wine apps) provided for some distro (Ubuntu 10.04, works on mandriva 2010, maybe others but break on recent xorg). I don't know exactly what to do : i don't want to break hypothetical support, even proprietary. Leaving the choice at kernel compile time seems to be safer, no ? -- Yann Cantin A4FEB47F -- -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html