Re: [PATCH v4] Input: synaptics - handle out of bounds values from the hardware

From
Seth Forshee <hidden>
Date
2012-07-25 13:47:21
Reply to
Daniel Kurtz, 2012-07-25
On Wed, Jul 25, 2012 at 10:50:15AM +0800, Daniel Kurtz wrote:
quoted
+       /* Convert wrap-around values to negative */
+       if (hw->x > X_MAX_POSITIVE)
+               hw->x = hw->x - (1 << ABS_POS_BITS);
Hi Seth,

Perhaps:
hw->x -= (1 << ABS_POS_BITS);
It makes no difference to me, either way it works the same. I don't
think I'll send another patch just to change this though, unless Dmitry
asks for it :)
Either way, it looks good, thanks!

Reviewed-by: Daniel Kurtz <redacted>
Thanks!

Seth
Thread (6 messages) 6 messages, 2 authors, last reply 2012-07-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help