RE: [PATCH] fixed a macro coding style issue
From: Venu Byravarasu <hidden>
Date: 2012-07-25 05:27:37
Also in:
lkml
quoted hunk ↗ jump to hunk
-----Original Message----- From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- owner@vger.kernel.org] On Behalf Of Baodong Chen Sent: Wednesday, July 25, 2012 10:51 AM To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Baodong Chen Subject: [PATCH] fixed a macro coding style issue Fixed a coding style issue in driver/input/input.c Signed-off-by: Baodong Chen <redacted> --- drivers/input/input.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)diff --git a/drivers/input/input.c b/drivers/input/input.c index 8921c61..c96e983 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c@@ -845,11 +845,13 @@ int input_set_keycode(struct input_dev *dev, EXPORT_SYMBOL(input_set_keycode); #define MATCH_BIT(bit, max) \ + do { \ for (i = 0; i < BITS_TO_LONGS(max); i++) \ if ((id->bit[i] & dev->bit[i]) != id->bit[i]) \ break; \ - if (i != BITS_TO_LONGS(max)) \ - continue; + if (i != BITS_TO_LONGS(max)) \ + continue; \
What is the need for extra indentation here?
+ } while (0) static const struct input_device_id *input_match_device(struct input_handler *handler, struct input_dev *dev) -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/