Re: [PATCH 2/2 v2] Input: synaptics - add sysfs access to firmware ID & board ID

On Wed, Jul 04, 2012 at 03:08:48PM +0200, Henrik Rydberg wrote:

On Wed, Jul 04, 2012 at 05:07:17PM +0800, Daniel Kurtz wrote:

quoted

Allow userspace to query firmware ID and board ID, which are read and
cached during device initialization.

This information can be read, for instance, by a userspace feedback
reporting tool, to include this information in its reports.

Signed-off-by: Daniel Kurtz <redacted>
---
 drivers/input/mouse/synaptics.c |   41 +++++++++++++++++++++++++++++++++++++++
 1 files changed, 41 insertions(+), 0 deletions(-)

Still reluctant here, but I am fine with whatever Dmitry thinks about it.

I do not think we need to have additional attributes - reporting
tools will collect kernel logs so since your previous change dumps the
data there that is all we need.

Thanks.

-- 
Dmitry