Re: [PATCH] Fix sentelic multi-touch driver
From: Olivier Goffart <hidden>
Date: 2012-06-29 07:52:39
On Friday 29 June 2012 11:03:12 Tai-hwa Liang wrote:
On Thu, 28 Jun 2012, Olivier Goffart wrote: [...]quoted
- Touch the touchpad with one finger and move it: this moves the cursor - Place a second finger: this allows you to scoll - Release a finger: you should now be able to move the cursor again. This is the part that does not work in one of the patchSorry, I didn't realise that one of my patch submitted a few months ago (namely, http://www.spinics.net/lists/linux-input/msg19443.html) isn't in the master tree, which is different from my local working copy. With the correct flag(FSP_BIT_SWC1_EN_GID) being set, the hardware clears MFMC bit during 2 -> 1 finger transition. The attached patch is an aggregated version against Dmitry's master branch, which supposes to fix the testing case listed above. Thanks, Tai-hwa Liang
I am testing against the stable 3.4.y branch. With that patch, scrolling is very slow, and it emits middle click sometimes while I want to scroll fast. Looking at the debug output, i see a lot of NOTIFY packets, for the same number of packets/seconds (77). So then there is 5 times less multi touch events. Maybe that's why. Regards -- Olivier