[PATCH v2 5/9] Input: tegra-kbc - add clk_prepare/clk_unprepare

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, tegra kbc driver, the rest

STALE5180d

2 messages, 2 authors, 2012-06-05 · open the first message on its own page

[PATCH v2 5/9] Input: tegra-kbc - add clk_prepare/clk_unprepare

From: Prashant Gaikwad <pgaikwad@nvidia.com>
Date: 2012-06-05 04:19:07

Use clk_prepare/clk_unprepare as required by the generic clk framework.

Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
---
This patch should go through Tegra tree since other patches to port tegra
to generic clock framework are dependent on it. Posting here to get ack from
the maintainers.

 drivers/input/keyboard/tegra-kbc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 4ffe64d..2c1c9ed 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -492,7 +492,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
 	unsigned int debounce_cnt;
 	u32 val = 0;
 
-	clk_enable(kbc->clk);
+	clk_prepare_enable(kbc->clk);
 
 	/* Reset the KBC controller to clear all previous status.*/
 	tegra_periph_reset_assert(kbc->clk);
@@ -556,7 +556,7 @@ static void tegra_kbc_stop(struct tegra_kbc *kbc)
 	disable_irq(kbc->irq);
 	del_timer_sync(&kbc->timer);
 
-	clk_disable(kbc->clk);
+	clk_disable_unprepare(kbc->clk);
 }
 
 static int tegra_kbc_open(struct input_dev *dev)
-- 
1.7.4.1

Re: [PATCH v2 5/9] Input: tegra-kbc - add clk_prepare/clk_unprepare

From: Shubhrajyoti <hidden>
Date: 2012-06-05 05:20:21

On Tuesday 05 June 2012 09:49 AM, Prashant Gaikwad wrote:
Use clk_prepare/clk_unprepare as required by the generic clk framework.
Not a comment just curious to know what does

clk_prepare/clk_unprepare do differently vis a vis enable.
Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
---

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help