2012/6/13 Hiremath, Vaibhav [off-list ref]

On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote:

quoted

From: Zumeng Chen <redacted>

If we don't set proper debouce time for ads7846, then there are
flooded interrupt counters of ads7846 responding to one time
touch on screen, so the driver couldn't work well.

And since most OMAP3 series boards pass NULL pointer of board_pdata
to omap_ads7846_init, so it's more proper to set it in driver level
after having gpio_request done.

This patch has been validated on 3530evm.

Signed-off-by: Zumeng Chen <redacted>
Signed-off-by: Syed Mohammed Khasim <redacted>
---
 drivers/input/touchscreen/ads7846.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/input/touchscreen/ads7846.c

b/drivers/input/touchscreen/ads7846.c

quoted

index f02028e..459ff29 100644

--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c

@@ -980,6 +980,10 @@ static int __devinit ads7846_setup_pendown(struct

spi_device *spi, struct ads784

quoted

              }

              ts->gpio_pendown = pdata->gpio_pendown;
+#ifdef CONFIG_ARCH_OMAP3
+             /* 310 means about 10 microsecond for omap3 */
+             gpio_set_debounce(pdata->gpio_pendown, 310);
+#endif

Zumeng,

With my sign-off you are changing the original code, that too
without my sign-off and ack.
I wouldn't mind you to submit patches from my tree, but the expectation is
if you are changing the original code, it should be under your sign-off.

Many thanks for your information, good to learn. I'll remove too. Sorry for
inconvenience.

Coming to the patch, #ifdef in driver is not recommended, and this 10msec
delay is specific to OMAP GPIO and driver should not be aware of this,
that's where you will find the original patch handling it in board file.

Yes, I just went through again the board related codes, there is a commit
from
Mike, I think that's the basic thoughts for me to do this patch for all
omap3 about
ads7846 :-)

Regards,
Zumeng

Thanks,
Vaibhav

quoted

      } else {
              dev_err(&spi->dev, "no get_pendown_state nor

gpio_pendown?\n");

quoted

--
1.7.5.4