Re: [PATCH] HID: wacom: Remove raport header check.

Dnia 2012-05-14, pon o godzinie 13:21 -0700, Ping Cheng pisze:

On Mon, May 14, 2012 at 9:13 AM, Przemo Firszt [off-list ref] wrote:

quoted

That check was valid when hid-wacom was only supporting Wacom Graphire, as the
device raports always start with 0x03. Intuos4 WL high-speed raports
begin with 0x04, so the check would be filtering out valid reports.

I assume the if-statement was added on purpose. It was most likely
used to filter noises for Graphire.

Should we change to

if (data[0] != 0x03 || (data[0] != 0x04 &&
    hdev->product == USB_DEVICE_ID_WACOM_INTUOS4_BLUETOOTH)) {

        hid_err(hdev, "Unknown report: %d,%d size:%d\n",
					data[0], data[1], size);
        return 0;
}

and remove default case for I4?

Or, remove the if-statement as you suggested and add a default case
for Graphire to post hid_err and exit when data[0] != 3.

Either way works for me.

Hi Ping,
Thanks for the comment. I'll go with the second option and I hope we
won't be generating too much noise in the logs :-)

Patches (there are 2 more for speed setting through sysfs for I4 WL) on
the way...
-- 
Regards,
Przemo Firszt [off-list ref]