Thread (9 messages) flat view 9 messages, 3 authors, 2012-05-04

Re: [bug?] [powerpc] hid_logitech_dj: Wireless mouse does not work in xorg or gpm

From: Nestor Lopez Casado <hidden>
Date: 2012-05-04 10:16:32
Subsystem: hid core layer, hid logitech drivers, the rest · Maintainers: Jiri Kosina, Benjamin Tissoires, Linus Torvalds

Possibly related (same subject, not in this thread)

Hi guys,

Thanks for those logs, very helpful.

Would you be able to test the following patch on both systems and let
us know about the result?

Cheers,
Nestor
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index 38b12e4..763e4d9 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -215,6 +215,7 @@ static void logi_dj_recv_add_djhid_device(struct
dj_receiver_dev *djrcv_dev,
 	struct usb_device *usbdev = interface_to_usbdev(intf);
 	struct hid_device *dj_hiddev;
 	struct dj_device *dj_dev;
+	u32 reports_supported;

 	/* Device index goes from 1 to 6, we need 3 bytes to store the
 	 * semicolon, the index, and a null terminator
@@ -264,9 +265,11 @@ static void logi_dj_recv_add_djhid_device(struct
dj_receiver_dev *djrcv_dev,
 			__func__);
 		goto dj_device_allocate_fail;
 	}
+	memcpy(&reports_supported,
+		&dj_report->report_params[DEVICE_PAIRED_RF_REPORT_TYPE],
+		sizeof(reports_supported));

-	dj_dev->reports_supported = le32_to_cpu(
-		dj_report->report_params[DEVICE_PAIRED_RF_REPORT_TYPE]);
+	dj_dev->reports_supported = le32_to_cpu(reports_supported);
 	dj_dev->hdev = dj_hiddev;
 	dj_dev->dj_receiver_dev = djrcv_dev;
 	dj_dev->device_index = dj_report->device_index;



On Fri, May 4, 2012 at 10:36 AM, Jonathan Nieder [off-list ref] wrote:
Hugo Osvaldo Barrera wrote:
quoted
Oh, it slipped my mind and I used the other (identical) mouse for this,
does that matter?  They're the exact same model.
Probably doesn't matter, but thanks for mentioning it.

Sincerely,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help